Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20379
to look at the new patch set (#9).
Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits
......................................................................
IMPALA-12383: Fix SingleNodePlanner aggregation limits
When IMPALA-2581 was implemented, it assumed all aggregation nodes would
have a pre-aggregation step that limits could be pushed to and therefore
removed limits on the final aggregation step. All distributed
aggregations have an exchange, and in practice the exchange would
enforce limits.
When num_nodes=1, that is not the case. As a result, the following query
would incorrectly return 16 rows, not 10:
set num_nodes=1;
select distinct l_orderkey from tpch.lineitem limit 10;
This fix restores limits on the aggregation node; in a distributed plan
using fast_limit_check, these should essentially be a no-op.
Testing:
- added a test case where we assert number of rows returned by an
aggregation node (rather than an exchange or top-n).
- restores definition of ALL_CLUSTER_SIZES and makes it simpler to
enable for individual test suites. Filed IMPALA-12394 to generally
re-enable testing with ALL_CLUSTER_SIZES. Enables ALL_CLUSTER_SIZES
for aggregation tests.
Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816
---
M be/src/exec/aggregation-node-base.cc
M be/src/exec/grouping-aggregator.cc
M be/src/exec/grouping-aggregator.h
M tests/common/impala_test_suite.py
M tests/common/test_dimensions.py
M tests/query_test/test_aggregation.py
6 files changed, 31 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/20379/9
--
To view, visit http://gerrit.cloudera.org:8080/20379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816
Gerrit-Change-Number: 20379
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
