Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 )
Change subject: IMPALA-12424: Allow third party JniFrontend interface. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " > They'd need to override this on any impalad and catalogd instances, right? Depending on what they modify, they might be able to skip catalogd. http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module."); Nit: Should we say something about the specified class being a subclass of JniFrontend? http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: <module>external-frontend</module> > Should we worry about this showing up in releases? Is there a test-only pro Since there is no dependency from fe or executor-deps (or anything else that fe depends on), it shouldn't be on our classpath or ship in our docker image. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 07 Sep 2023 05:30:54 +0000 Gerrit-HasComments: Yes
