Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20443 )
Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ ...................................................................... Patch Set 1: (2 comments) These changes seem safe enough. I'd like to understand whether there's a bigger issue here. Has some rebase conflicts that'll need to be resolved. http://gerrit.cloudera.org:8080/#/c/20443/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/20443/1/be/src/runtime/exec-env.cc@127 PS1, Line 127: "If --use_local_catalog is enabled, configures the local cache's consistency " Why introduce a new term (consistency) instead of use concurrency? http://gerrit.cloudera.org:8080/#/c/20443/1/be/src/runtime/exec-env.cc@128 PS1, Line 128: "level to avoid lock contention , the default value 4 is consistent with the " nit: remove space before comma. -- To view, visit http://gerrit.cloudera.org:8080/20443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e3c10660e371498c2edc1eb8d235b7b8ca170c9 Gerrit-Change-Number: 20443 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Thu, 07 Sep 2023 21:45:59 +0000 Gerrit-HasComments: Yes
