Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 )
Change subject: IMPALA-10086: Implicit cast comparing char and varchar ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20425/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20425/3//COMMIT_MSG@14 PS3, Line 14: number of : arguments match Nit: 'number of arguments _that_ match'? http://gerrit.cloudera.org:8080/#/c/20425/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/20425/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@1574 PS3, Line 1574: more specific compatible type Do we know that 'type' is always the more specific type and not 'targetType'? Is it because Type.getAssignmentCompatibleType() doesn't return wildcard types? If so, it could be included in the comment. http://gerrit.cloudera.org:8080/#/c/20425/3/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/20425/3/tests/query_test/test_cast_with_format.py@2191 PS3, Line 2191: self.execute_query("drop table if exists " + table) I don't think we need this, 'unique_database' will always start out as empty. -- To view, visit http://gerrit.cloudera.org:8080/20425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89d0a391bc8f2152ecd9151c8872a01ba19c436 Gerrit-Change-Number: 20425 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 12:54:24 +0000 Gerrit-HasComments: Yes
