Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 )
Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/18581/7/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java File fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java: http://gerrit.cloudera.org:8080/#/c/18581/7/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java@186 PS7, Line 186: is Nit: are. http://gerrit.cloudera.org:8080/#/c/18581/7/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java File fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java: http://gerrit.cloudera.org:8080/#/c/18581/7/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@95 PS7, Line 95: into Nit: to? http://gerrit.cloudera.org:8080/#/c/18581/7/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/18581/7/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@152 PS7, Line 152: // Values stmt - expression rewrites are disabled. This is no longer completely true - we should update the comment to say something like expression rewrites are enabled except for || and the Between predicate, or that most expression rewrites are disabled. http://gerrit.cloudera.org:8080/#/c/18581/7/testdata/workloads/functional-query/queries/QueryTest/values.test File testdata/workloads/functional-query/queries/QueryTest/values.test: http://gerrit.cloudera.org:8080/#/c/18581/7/testdata/workloads/functional-query/queries/QueryTest/values.test@148 PS7, Line 148: create table values_11284(col string, value boolean); You don't need to create a table, you could run a select query like this: select * from ( values (concat("a", "b" || "c"), 1 <= 2 AND ((0.5 BETWEEN 0 AND 1) AND (true || false))), ("hello" || "world", 0 <= 1 || 0.5 < 0.6), ("impala", 4.0 BETWEEN 3.2 AND 4.1), ("sql", 'a' NOT BETWEEN 'b' AND 'c') ) t; -- To view, visit http://gerrit.cloudera.org:8080/18581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b8b33bf6468d12b9e26f0a6e744feb7072619c Gerrit-Change-Number: 18581 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Sep 2023 13:29:46 +0000 Gerrit-HasComments: Yes
