Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 )
Change subject: IMPALA-12424: Allow third party JniFrontend interface. ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module. Th > Does it have to be though? I think an implementor can reimplement all the You're right, it just needs to implement the appropriate methods. The new message looks good. -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Sep 2023 15:39:53 +0000 Gerrit-HasComments: Yes
