Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 )
Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15 PS2, Line 15: Fix: Use char literals rather than string literals > Oops, done Done http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@23 PS2, Line 23: you can either change the type to the correct one ('$TYPE' but > Good point, I was missing the rest. Fixed Done -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Sep 2023 21:52:44 +0000 Gerrit-HasComments: Yes
