Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20460 )
Change subject: IMPALA-12371: Add better cardinality estimation for Iceberg V2 tables with deletes ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20460/2/fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java: http://gerrit.cloudera.org:8080/#/c/20460/2/fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java@98 PS2, Line 98: is not zero > If there are input files to scan, leftCard will always be greater than 0, s Thanks, I like the idea about a precondition check and using 1 in the Math.math() call. http://gerrit.cloudera.org:8080/#/c/20460/2/fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java@100 PS2, Line 100: leftCard > Yes. Thanks. It may be worth mentioning it either here or in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/20460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I988dc8d7e1074932c460b3702d3381341e5b23c5 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 11 Sep 2023 11:19:54 +0000 Gerrit-HasComments: Yes
