Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20474 )
Change subject: IMPALA-12411: Fix data race in expr-test teardown ...................................................................... IMPALA-12411: Fix data race in expr-test teardown TSAN ThreadSanitizer detected a data race during expr-test teardown when a query finishes after JvmMetricCache's destructor is called. expr-test can finish with a query still running because ImpaladQueryExecutor closes the previous query when you start the next query and relies on the destructor to close the last query. expr-test creates ImpaladQueryExecutor as a global as part of setting up an in-memory cluster (with Statestore and InProcessImpalaServer). So the last query isn't guaranteed to be closed until global destruction, which leads to a race with other global destruction (in this case with JvmMetricCache while updating QueryState on query completion). ImpaladQueryExecutor is only used in expr-test. Change-Id: I8e289b292cb11154f1245e2b987cde0995b6243c Reviewed-on: http://gerrit.cloudera.org:8080/20474 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/expr-test.cc 1 file changed, 15 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/20474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8e289b292cb11154f1245e2b987cde0995b6243c Gerrit-Change-Number: 20474 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
