Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 )
Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/18126/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18126/2//COMMIT_MSG@27 PS2, Line 27: n is i > Nit: could be "is intended to offer" Done http://gerrit.cloudera.org:8080/#/c/18126/2//COMMIT_MSG@30 PS2, Line 30: tion not s > Mention that we also fall back to the flag if the query option is set no ze Done http://gerrit.cloudera.org:8080/#/c/18126/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/18126/2/be/src/exec/hdfs-scan-node.cc@220 PS2, Line 220: from : // either of the HDFS_SCANNER_NON_RESERVED_BYTES query op > Nit: it would be better like this: Done. Rephrased. http://gerrit.cloudera.org:8080/#/c/18126/2/be/src/exec/hdfs-scan-node.cc@221 PS2, Line 221: ion or the : // hdfs_scanner_thread_max_estimated_byte > Nit: it would be better like this: Done. Rephrased. http://gerrit.cloudera.org:8080/#/c/18126/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/18126/2/common/thrift/ImpalaService.thrift@847 PS2, Line 847: by the pla > Nit: by the planner. Done http://gerrit.cloudera.org:8080/#/c/18126/2/common/thrift/ImpalaService.thrift@849 PS2, Line 849: al sca > Nit: threads. Done http://gerrit.cloudera.org:8080/#/c/18126/2/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/18126/2/common/thrift/Query.thrift@665 PS2, Line 665: 166: optional i64 hdfs_scanner_non_reserved_bytes = -1 > Shouldn't the default be unset, i.e. for example -1? That way the original Agree. Done. -- To view, visit http://gerrit.cloudera.org:8080/18126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03cadf1230eed00d69f2890c82476c6861e37466 Gerrit-Change-Number: 18126 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 12 Sep 2023 17:42:48 +0000 Gerrit-HasComments: Yes
