Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20169
to look at the new patch set (#4).
Change subject: PROTOTYPE: Put all thrift-generated python code into the
impala_thrift_gen package
......................................................................
PROTOTYPE: Put all thrift-generated python code into the impala_thrift_gen
package
This mimics what Impyla does for its thrift-generated python
code, except that it uses the "impala_thrift_gen" package
rather than "impala._thrift_gen".
This involves patching all of the thrift files to add the
python namespace, as well as patching the thirdparty thrift
files (hive_metastore.thrift, fb303.thrift) to do the same.
Putting all the generated python into a package makes it easier
to understand where the imports are getting code. It also means
that future changes that rearrange the shell code can avoid
putting the thrift generated code in the same directory as
the regular impala shell code.
Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0
---
A bin/cmake_aux/add_thrift_python_namespace.sh
M common/thrift/.gitignore
M common/thrift/BackendGflags.thrift
M common/thrift/CMakeLists.txt
M common/thrift/CatalogInternalService.thrift
M common/thrift/CatalogObjects.thrift
M common/thrift/CatalogService.thrift
M common/thrift/Data.thrift
M common/thrift/DataSinks.thrift
M common/thrift/Descriptors.thrift
M common/thrift/ExecStats.thrift
M common/thrift/Exprs.thrift
M common/thrift/ExternalDataSource.thrift
M common/thrift/Frontend.thrift
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/JniCatalog.thrift
M common/thrift/LineageGraph.thrift
M common/thrift/Logging.thrift
M common/thrift/Metrics.thrift
M common/thrift/NetworkTest.thrift
M common/thrift/Partitions.thrift
M common/thrift/PlanNodes.thrift
M common/thrift/Planner.thrift
M common/thrift/Query.thrift
M common/thrift/ResourceProfile.thrift
M common/thrift/Results.thrift
M common/thrift/RuntimeProfile.thrift
M common/thrift/SqlConstraints.thrift
M common/thrift/StatestoreService.thrift
M common/thrift/Status.thrift
M common/thrift/Types.thrift
M common/thrift/Zip.thrift
M common/thrift/beeswax.thrift
M common/thrift/generate_error_codes.py
M common/thrift/generate_metrics.py
M common/thrift/hive-1-api/TCLIService.thrift
M common/thrift/parquet.thrift
M lib/python/impala_py_lib/profiles.py
M shell/impala_client.py
M shell/value_converter.py
M testdata/bin/wait-for-hiveserver2.py
M testdata/bin/wait-for-metastore.py
M tests/authorization/test_authorization.py
M tests/authorization/test_authorized_proxy.py
M tests/beeswax/impala_beeswax.py
M tests/catalog_service/test_catalog_service_client.py
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_admission_controller.py
M tests/custom_cluster/test_blacklist.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_delegation.py
M tests/custom_cluster/test_events_custom_configs.py
M tests/custom_cluster/test_hs2.py
M tests/custom_cluster/test_metastore_service.py
M tests/custom_cluster/test_process_failures.py
M tests/custom_cluster/test_query_retries.py
M tests/custom_cluster/test_restart_services.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/hs2_test_suite.py
M tests/hs2/test_fetch.py
M tests/hs2/test_fetch_first.py
M tests/hs2/test_fetch_timeout.py
M tests/hs2/test_hs2.py
M tests/hs2/test_json_endpoints.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_ddl.py
M tests/metadata/test_load.py
M tests/query_test/test_acid.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_iceberg.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_observability.py
M tests/query_test/test_parquet_bloom_filter.py
M tests/query_test/test_parquet_page_index.py
M tests/query_test/test_query_opts.py
M tests/query_test/test_scanners.py
M tests/statestore/test_statestore.py
M tests/util/acid_txn.py
M tests/util/event_processor_utils.py
M tests/util/get_parquet_metadata.py
M tests/util/parse_util.py
83 files changed, 246 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/20169/4
--
To view, visit http://gerrit.cloudera.org:8080/20169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0
Gerrit-Change-Number: 20169
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
