Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18581 )
Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate ...................................................................... IMPALA-11284: Do non-optional rewrites for || and Between predicate IMPALA-6590 disabled expression rewrites for ValuesStmt. However, CompoundVerticalBarExpr (||) cannot be executed directly without rewrite. This is because it could either be an OR operation with boolean arguments or CONCAT function call with string arguments. Backend cannot evaluate a BetweenPredicate and relies on rewriting BetweenPredicate into a conjunctive or disjunctive CompoundPredicate. This patch enables non-optional expression rewrites for ValuesStmt with CompoundVerticalBarExpr or BetweenPredicate. Testing: - Extended ExprRewriterTest and Planner test to have values clause with || and Between predicate Change-Id: I99b8b33bf6468d12b9e26f0a6e744feb7072619c Reviewed-on: http://gerrit.cloudera.org:8080/18581 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Daniel Becker <[email protected]> Tested-by: Riza Suminto <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/ValuesStmt.java M fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java M testdata/workloads/functional-query/queries/QueryTest/values.test 4 files changed, 54 insertions(+), 7 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Daniel Becker: Looks good to me, approved Riza Suminto: Verified -- To view, visit http://gerrit.cloudera.org:8080/18581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I99b8b33bf6468d12b9e26f0a6e744feb7072619c Gerrit-Change-Number: 18581 Gerrit-PatchSet: 12 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
