Sai Hemanth Gantasala has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20486 )

Change subject: IMPALA-12356: Alter partition event from hive is treated as 
self event
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG@9
PS6, Line 9: using
           : insert
Do you mean dynamic partition insert?
Does it happen with alter table add partition operation?


http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG@12
PS6, Line 12: It was
            : missed to avoid the addition of version number
nit: can you rephrase this? It is really not clear


http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG@19
PS6, Line 19: - Manually tested in cluster and added a testcase
Can you also add an end-to-end test to prove that the alter partition event 
from hive will not be treated as self event?



--
To view, visit http://gerrit.cloudera.org:8080/20486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3
Gerrit-Change-Number: 20486
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Mon, 18 Sep 2023 21:08:11 +0000
Gerrit-HasComments: Yes

Reply via email to