Hello Andrew Sherman, Gabor Kaszab, Peter Rozsa, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20477
to look at the new patch set (#2).
Change subject: IMPALA-12313: (part 1) Refactor modify statements
......................................................................
IMPALA-12313: (part 1) Refactor modify statements
This change refactors the classes and methods that implement
modify statements like DELETE and UPDATE. ModifyStmt, DeleteStmt,
UpdateStmt are created during parsing and contain information about
the statement: FROM clause, WHERE clause, target table, etc.
The logic that actually implements these operations is dependent
on the type of the target table. Therefore during analysis, after
the target table is resolved, we create the *Impl object (e.g.
IcebergDeleteImpl, KuduUpdateImpl) that implements the logic. The
impl object is in charge of creating the source statement of the
operation, doing the necessary rewrites/masking, and also creating
the data sink.
Testing:
* N/A: no new functionality / bug fix
Change-Id: If15f64944f2e23064b7112ad5930abc775dd65ec
---
M fe/src/main/java/org/apache/impala/analysis/DeleteStmt.java
M fe/src/main/java/org/apache/impala/analysis/DmlStatementBase.java
A fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
A fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
A fe/src/main/java/org/apache/impala/analysis/KuduDeleteImpl.java
A fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java
A fe/src/main/java/org/apache/impala/analysis/KuduUpdateImpl.java
A fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java
M fe/src/main/java/org/apache/impala/analysis/UpdateStmt.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
11 files changed, 641 insertions(+), 343 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/20477/2
--
To view, visit http://gerrit.cloudera.org:8080/20477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If15f64944f2e23064b7112ad5930abc775dd65ec
Gerrit-Change-Number: 20477
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
