Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20496 )
Change subject: WIP - Small String Optimization ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/runtime/string-value.h File be/src/runtime/string-value.h: http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/runtime/string-value.h@54 PS2, Line 54: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/runtime/string-value.h@117 PS2, Line 117: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/runtime/string-value.h@122 PS2, Line 122: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/runtime/string-value.h@159 PS2, Line 159: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/runtime/string-value.h@237 PS2, Line 237: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/util/url-parser.cc File be/src/util/url-parser.cc: http://gerrit.cloudera.org:8080/#/c/20496/2/be/src/util/url-parser.cc@196 PS2, Line 196: (trimmed_url.Ptr()[key_pos - 1] != '?' && trimmed_url.Ptr()[key_pos - 1] != '&')) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741c3a5f12ab620b6b64b57d4c89b5f8e056efd3 Gerrit-Change-Number: 20496 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 20 Sep 2023 09:01:56 +0000 Gerrit-HasComments: Yes
