Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20443 )
Change subject: IMPALA-12402: Make CatalogdMetaProvider's cache concurrency level configurable ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20443/7/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/20443/7/be/src/util/backend-gflag-util.cc@441 PS7, Line 441: cfg.__set_max_filter_error_rate_from_full_scan( > Oh, you also need to set the thrift flag from the CLI flag here to pass it Done http://gerrit.cloudera.org:8080/#/c/20443/10/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/20443/10/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@369 PS10, Line 369: concurrencyLevel); If you look in the logs from the test failure, there are some frontend tests in CatalogdMetaProviderTest.java that use a default TBackendGflags. One option would be to handle a default value (0) and reset it to 4; CacheBuilder considers 0 an illegal value. You could also update CatalogdMetaProviderTest's constructor to initialize the value (which would be more targeted and prevent mistakes like we made missing the handoff from backend to frontend). -- To view, visit http://gerrit.cloudera.org:8080/20443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e3c10660e371498c2edc1eb8d235b7b8ca170c9 Gerrit-Change-Number: 20443 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 20 Sep 2023 17:48:00 +0000 Gerrit-HasComments: Yes
