Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20505 )
Change subject: WIP: IMPALA-12462: Update only changed partitiones after COMPUTE STATS ...................................................................... Patch Set 2: (3 comments) LGTM http://gerrit.cloudera.org:8080/#/c/20505/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20505/2//COMMIT_MSG@15 PS2, Line 15: Todo: add/update tests We can add a test of running the same COMPUTE STATS command twice, and see if the second one updates any partitions. http://gerrit.cloudera.org:8080/#/c/20505/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20505/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1898 PS2, Line 1898: String.valueOf(numRows); nit: this can be put into the equals() call below. So when 'existingRowCount' is null, we don't need to convert the integer to string. http://gerrit.cloudera.org:8080/#/c/20505/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1905 PS2, Line 1905: String.format( nit: we can use the slf4j api to avoid String.format(). LOG.trace("{} stats for partition {}: numRows={}", updatedPartition ? "Updating" : "Skip updating", partition.getValuesAsString(), numRows); -- To view, visit http://gerrit.cloudera.org:8080/20505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2703e0790d5c25db98ed26f26f6d96281c366a3 Gerrit-Change-Number: 20505 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 24 Sep 2023 13:26:38 +0000 Gerrit-HasComments: Yes
