[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/19954 )
Change subject: [arm64] remove dependence on sse2neon ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/19954/10/be/src/util/sse-util.h File be/src/util/sse-util.h: http://gerrit.cloudera.org:8080/#/c/19954/10/be/src/util/sse-util.h@296 PS10, Line 296: #define SSE4_crc32_u8 __crc32cb : #define SSE4_crc32_u16 __crc32ch : #define SSE4_crc32_u32 __crc32cw : #define SSE4_crc32_u64 __crc32cd > This section is used for compiling the LLVM IR on ARM. If we duplicate the Done http://gerrit.cloudera.org:8080/#/c/19954/6/be/src/util/sse-util.h File be/src/util/sse-util.h: http://gerrit.cloudera.org:8080/#/c/19954/6/be/src/util/sse-util.h@179 PS6, Line 179: static inline int POPCNT_popcnt_u64(uint64_t x) { > If I understand the code correctly, I think we would also need to change th Done -- To view, visit http://gerrit.cloudera.org:8080/19954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3c78c877ef530fa9f35d36da523ad67ab34e5e7 Gerrit-Change-Number: 19954 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Sun, 24 Sep 2023 17:46:07 +0000 Gerrit-HasComments: Yes
