Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20505 )
Change subject: IMPALA-12462: Update only changed partitiones after COMPUTE STATS ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20505/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20505/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1891 PS4, Line 1891: !existingPartStats.equals(partitionStats) > For COMPUTE INCREMENTAL STATS (without partition spec), will all the partit Checked this: COMPUTE INCREMENTAL STATS only alters the new partitions by default, or the partitions selected explicitly in COMPUTE INCREMENTAL STATS t PARTITION (...). So the only effect of this patch on incremental stats should be that if a partition was explicitly selected, but there is actually no change, then we don't update it in HMS. This is the right thing to do in my opinion as HMS changes can be extremely slow. -- To view, visit http://gerrit.cloudera.org:8080/20505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2703e0790d5c25db98ed26f26f6d96281c366a3 Gerrit-Change-Number: 20505 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2023 09:40:00 +0000 Gerrit-HasComments: Yes
