Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20508 )

Change subject: IMPALA-12398: Ranger role not exists when altering 
db/table/view owner to a role
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java
File 
fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java:

http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@46
PS1, Line 46:     protected CatalogServiceTestCatalog4Ranger(boolean 
loadInBackground, int numLoadingThreads,
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@47
PS1, Line 47:                                       MetaStoreClientPool 
metaStoreClientPool) throws ImpalaException {
line too long (103 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@55
PS1, Line 55:     public static CatalogServiceTestCatalog4Ranger 
createWithAuth(AuthorizationFactory factory) {
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@62
PS1, Line 62:             cs = new CatalogServiceTestCatalog4Ranger(false, 16, 
new MetaStoreClientPool(0, 0));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@63
PS1, Line 63:             RangerImpalaPlugin rangerImpalaPlugin = 
((RangerAuthorizationChecker)factory.newAuthorizationChecker()).getRangerImpalaPlugin();
line too long (140 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@72
PS1, Line 72:             cs.setEventFactoryForSyncToLatestEvent(new 
MetastoreEvents.EventFactoryForSyncToLatestEvent(
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/authorization/CatalogServiceTestCatalog4Ranger.java@110
PS1, Line 110:                 RangerRole.RoleMember roleMember = new 
RangerRole.RoleMember(s,s.equals(RANGER_ADMIN_USER));
line too long (108 > 90)


http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
File fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java:

http://gerrit.cloudera.org:8080/#/c/20508/1/fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java@49
PS1, Line 49:                                       MetaStoreClientPool 
metaStoreClientPool) throws ImpalaException {
line too long (103 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/20508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b029bdb90111dbd0eab5189360cc81090225cda
Gerrit-Change-Number: 20508
Gerrit-PatchSet: 1
Gerrit-Owner: ji chen <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 25 Sep 2023 15:09:11 +0000
Gerrit-HasComments: Yes

Reply via email to