Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20496 )
Change subject: IMPALA-12373: Small String Optimization for StringValue ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/20496/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20496/4//COMMIT_MSG@46 PS4, Line 46: Benefits: > Yes, I didn't change anything when we are creating the strings during SCANs Ack http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/smallable-string.h File be/src/runtime/smallable-string.h: http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/smallable-string.h@77 PS4, Line 77: /// s must be a null-terminated string. This constructor is to prevent > Done Done http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/smallable-string.h@83 PS4, Line 83: memcpy(this, &other, sizeof(*this)); > Added sentence about it to the class comment. Done http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/smallable-string.h@100 PS4, Line 100: bool Smallify() { > Yes, removed this branch. Done http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/smallable-string.h@132 PS4, Line 132: SetSmallLen(len); > You are right, moved the DCHECK to the beginning. Done http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/smallable-string.h@170 PS4, Line 170: > Changed it to uint32_t. Done -- To view, visit http://gerrit.cloudera.org:8080/20496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741c3a5f12ab620b6b64b57d4c89b5f8e056efd3 Gerrit-Change-Number: 20496 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2023 17:34:03 +0000 Gerrit-HasComments: Yes
