Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20522 )
Change subject: IMPALA-12473: Fix profile's missing event timestamp exception in query timeline ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20522/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20522/1//COMMIT_MSG@10 PS1, Line 10: plotting nit: wrap the long line http://gerrit.cloudera.org:8080/#/c/20522/1/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/20522/1/www/query_timeline.tmpl@300 PS1, Line 300: for (var en = (i + 1) % fevents.length; en != i; en = (en + 1) % Are fevents and fp.child_profiles[instance].event_sequences[0].events in same order. If yes, we can compare two event lists without two loops, like sorted merge. -- To view, visit http://gerrit.cloudera.org:8080/20522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025b00d8632a5a1953ecdaaa7d8a4ae224dd2610 Gerrit-Change-Number: 20522 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2023 22:25:17 +0000 Gerrit-HasComments: Yes
