Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 )
Change subject: IMPALA-12356: Alter partition event from hive is treated as self event ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG@9 PS6, Line 9: : transa > Do you mean dynamic partition insert? Can you answer this question? http://gerrit.cloudera.org:8080/#/c/20486/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20486/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4537 PS8, Line 4537: params.get(MetastoreEventPropertyKey.CATALOG_SERVICE_ID.getKey()))) { Should we check whether the key 'CATALOG_SERVICE_ID' exists in the table parameters or not? Or you could use map.getOrDefult('CATALOG_SERVICE_ID', ""); Otherwise we would be hitting NullPointerException here. http://gerrit.cloudera.org:8080/#/c/20486/8/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/20486/8/tests/metadata/test_event_processing.py@456 PS8, Line 456: assert [(new_part_location,)] == partitions Can you also assert that the number of events processed before and after changed? Just to verify that query from hive is not treated as self event? -- To view, visit http://gerrit.cloudera.org:8080/20486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3 Gerrit-Change-Number: 20486 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2023 16:11:14 +0000 Gerrit-HasComments: Yes
