Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20537 )
Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) I've definitely run into this, seems useful. http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/20537/1/be/src/statestore/statestore-subscriber.cc@221 PS1, Line 221: new RpcEventHandler("statestore-subscriber", metrics_, 3)); nit: add a comment about what the 3 here means, like "Logging statestore subscriber heartbeats at VLOG_RPC to avoid overwhelming lower log levels." -- To view, visit http://gerrit.cloudera.org:8080/20537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add Gerrit-Change-Number: 20537 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2023 16:42:37 +0000 Gerrit-HasComments: Yes
