Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20537 )
Change subject: IMPALA-12482: Make VLOG level of RpcEventHandler adjustable ...................................................................... IMPALA-12482: Make VLOG level of RpcEventHandler adjustable Not all RPC need to print logs at VLOG level 2. For example, StatestoreSubscriber.UpdateState is a periodic RPC that happens every 1 second. Debugging impalad through lowering VLOG lovel to 2 has been difficult due to noise from this StatestoreSubscriber.UpdateState RPC that buries other more important log lines. This patch add vlog_level parameter in RpcEventHandler to make log level for different kind of RPC adjustable. Testing: - Manually test that log lines from StatestoreSubscriber.UpdateState is not printed anymore after lowering backend VLOG level to 2. Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add Reviewed-on: http://gerrit.cloudera.org:8080/20537 Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/rpc/rpc-trace.cc M be/src/rpc/rpc-trace.h M be/src/statestore/statestore-subscriber.cc 3 files changed, 19 insertions(+), 9 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/20537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic7658ee0016411a9ace0ca3f2eb535b03d2a7add Gerrit-Change-Number: 20537 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
