Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 )
Change subject: IMPALA-11068: Add query option to reduce scanner thread launch. ...................................................................... Patch Set 6: (1 comment) Just one comment, otherwise +1. http://gerrit.cloudera.org:8080/#/c/18126/6/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/18126/6/be/src/service/query-options.cc@1146 PS6, Line 1146: query_options->__set_mem_limit_coordinators(mem_spec_val.value); A break is missing from the end of the block here. -- To view, visit http://gerrit.cloudera.org:8080/18126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03cadf1230eed00d69f2890c82476c6861e37466 Gerrit-Change-Number: 18126 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 07 Oct 2023 00:30:12 +0000 Gerrit-HasComments: Yes
