Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 )
Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/20344/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/20344/2/be/src/service/impala-hs2-server.cc@479 PS2, Line 479: RETURN_IF_ERROR(return_val, THandleIdentifi > Please add a comment here: Done http://gerrit.cloudera.org:8080/#/c/20344/5/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/20344/5/be/src/service/impala-hs2-server.cc@1011 PS5, Line 1011: > I see. So is it possible that the cloudera jdbc driver hang on this request When I dived into GetLog() I found that the 'log' field of 'return_val' parameter won't be nullptr, so there is no problem for GetLog() interface. http://gerrit.cloudera.org:8080/#/c/20344/5/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20344/5/tests/common/impala_test_suite.py@1019 PS5, Line 1019: run_impala_stmt_in > I think we can leave 'run_stmt_in_hive' using its original name. The TODO a Done http://gerrit.cloudera.org:8080/#/c/20344/5/tests/shell/test_beeline.py File tests/shell/test_beeline.py: http://gerrit.cloudera.org:8080/#/c/20344/5/tests/shell/test_beeline.py@21 PS5, Line 21: from tests.common.impala_test_suite import ImpalaTestSuite > unused imports? Done http://gerrit.cloudera.org:8080/#/c/20344/5/tests/shell/test_beeline.py@27 PS5, Line 27: assert self.run_impala_stmt_in_beeline(stmt, None, unique_database) == "name\n" > Let's create the new table in 'unique_database'. We just need a new paramet Done http://gerrit.cloudera.org:8080/#/c/20344/5/tests/shell/test_beeline.py@29 PS5, Line 29: assert self.run_impala_stmt_in_beeline(stmt, None, unique_database) == \ > Can we verify the results? Done -- To view, visit http://gerrit.cloudera.org:8080/20344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib42bb82735fb4a8e6911b6a19adb8bd84973300b Gerrit-Change-Number: 20344 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Sun, 08 Oct 2023 02:53:28 +0000 Gerrit-HasComments: Yes
