Surya Hebbar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20355 )

Change subject: IMPALA-12364: Display memory, disk and network metrics in 
webUI's query timeline
......................................................................


Patch Set 19:

> We need to do something different for the zooming and scrolling as
 > it's hard to figure out how to control it, especially with a track
 > pad. The grey bar seems out of place and is confusing. I think it
 > would be better to have buttons to control the  zoom. Panning
 > should work via click and drag or buttons.

Now, I have added buttons for zooming in and out. And I have replaced the grey 
bar with a drag handle. This handle has extended length as to allow for 
resizing when zoomed in.


--
To view, visit http://gerrit.cloudera.org:8080/20355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd25e6f0bc9fbd664ec98936daff3f27182dfc7f
Gerrit-Change-Number: 20355
Gerrit-PatchSet: 19
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 09 Oct 2023 13:03:50 +0000
Gerrit-HasComments: No

Reply via email to