Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17842 )

Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables
......................................................................


Patch Set 28:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17842/27//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17842/27//COMMIT_MSG@13
PS27, Line 13:   - It is not distributed, e.g, fregment is unpartitioned. The 
queries
> Unclear what this actually means. Queries executed on the coordinator?
The fragment is unpartitioned, one instance for each query, and queries are 
executed on coordinator. The Plan is like:

F00:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1
|  Per-Host Resources: mem-estimate=1.00GB mem-reservation=4.00MB 
thread-reservation=1
PLAN-ROOT SINK
|  output exprs: id, bool_col, Int_col
|  mem-estimate=4.00MB mem-reservation=4.00MB spill-buffer=2.00MB 
thread-reservation=0
|
00:SCAN DATA SOURCE [functional.alltypes_jdbc_datasource]
   limit: 10


http://gerrit.cloudera.org:8080/#/c/17842/27//COMMIT_MSG@14
PS27, Line 14:     are executed on coordinator.
> Change wording:
fixed.


http://gerrit.cloudera.org:8080/#/c/17842/27//COMMIT_MSG@16
PS27, Line 16:     are not supported:
> Will between/in/like planned be supported in the future?
Yes


http://gerrit.cloudera.org:8080/#/c/17842/27//COMMIT_MSG@43
PS27, Line 43:
> Does this require mincluster restart?
No



--
To view, visit http://gerrit.cloudera.org:8080/17842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2
Gerrit-Change-Number: 17842
Gerrit-PatchSet: 28
Gerrit-Owner: Fucun Chu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fucun Chu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 09 Oct 2023 18:21:05 +0000
Gerrit-HasComments: Yes

Reply via email to