Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20428 )
Change subject: IMPALA-9118: Show catalog operation details in catalogd webUI ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20428/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20428/4/be/src/catalog/catalog-server.cc@152 PS4, Line 152: operation > nit: operation log records Done http://gerrit.cloudera.org:8080/#/c/20428/4/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/20428/4/be/src/exec/catalog-op-executor.cc@163 PS4, Line 163: Missing query id here. Fixed in PS5. http://gerrit.cloudera.org:8080/#/c/20428/4/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/20428/4/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@119 PS4, Line 119: if (ddlRequest.ddl_type == TD > Users might find it confusing if the DDL Summary would show a different num I think missing the header here should be considered as a bug. But to be compatible with old version impalads during rolling upgrade, it'd be better to keep this. -- To view, visit http://gerrit.cloudera.org:8080/20428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cf3f0da2be2be79e546762a8083d4de338ff6aa Gerrit-Change-Number: 20428 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Thu, 12 Oct 2023 06:02:19 +0000 Gerrit-HasComments: Yes
