Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20591 )

Change subject: IMPALA-12505: Define a new impala flag that runs the trusted 
domain check on the origin address if the trusted_domain_use_xff_header flag is 
enabled and no X-Forwarded-For header is received
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20591/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java:

http://gerrit.cloudera.org:8080/#/c/20591/1/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@526
PS1, Line 526:     // Case 2: Authenticate as 'Test1Ldap' without password, do 
not send X-Forwarded-For header
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/20591/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:

http://gerrit.cloudera.org:8080/#/c/20591/1/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@331
PS1, Line 331:     // Case 2: Authenticate as 'Test1Ldap' without password, do 
not send X-Forwarded-For header
line too long (95 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/20591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e5d1119527139eafaa411b55517b10bf394bb2
Gerrit-Change-Number: 20591
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Farkas <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 18 Oct 2023 14:27:34 +0000
Gerrit-HasComments: Yes

Reply via email to