Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20588 )
Change subject: IMPALA-12504: Split graphical query timeline script into es6 modules ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/chart_commons.js@55 PS1, Line 55: var j = max_samples.available + (extend? 3 : 2); nit: add a space before '?' http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/chart_commons.js@56 PS1, Line 56: (; nit: add a space after ';' http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/chart_commons.js@79 PS1, Line 79: indent with 4 spaces http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/chart_commons.js@106 PS1, Line 106: } put '}' in separate line. http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/fragment_diagram.js@39 PS1, Line 39: , nit: move ',' to the end of previous line http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/fragment_diagram.js@67 PS1, Line 67: } nit: put '}' in separate line http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/fragment_diagram.js@143 PS1, Line 143: , nit: move ',' to the end of previous line http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/fragment_diagram.js@359 PS1, Line 359: i++; factor ++i out of branches http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/host_utilization_diagram.js@122 PS1, Line 122: nit: two more spaces. http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/host_utilization_diagram.js@127 PS1, Line 127: nit: two more spaces. http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/query_timeline/host_utilization_diagram.js@197 PS1, Line 197: nit: two more spaces http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/util.js@18 PS1, Line 18: precision Should we set default value for precision? This function is called in line #81 without passing precision. http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/util.js@25 PS1, Line 25: + Should we keep a space ' '? http://gerrit.cloudera.org:8080/#/c/20588/1/www/scripts/util.js@81 PS1, Line 81: getReadableSize(data); Need to pass second parameter -- To view, visit http://gerrit.cloudera.org:8080/20588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d62a799d838876509686a75ecea778b2c72cc6 Gerrit-Change-Number: 20588 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 19 Oct 2023 21:53:41 +0000 Gerrit-HasComments: Yes
