Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20496 )
Change subject: IMPALA-12373: Small String Optimization for StringValue ...................................................................... Patch Set 7: (2 comments) Fixed a few bugs, mostly related to codegen. http://gerrit.cloudera.org:8080/#/c/20496/7/be/src/exec/parquet/parquet-common.h File be/src/exec/parquet/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/20496/7/be/src/exec/parquet/parquet-common.h@577 PS7, Line 577: fixed_len_size < str_len > Are you sure it's correct? This is different from what we did before, and n If fixed_len_size is greater than 0 then it still caps the length of 'v' or am I missing something? http://gerrit.cloudera.org:8080/#/c/20496/7/be/src/runtime/smallable-string.h File be/src/runtime/smallable-string.h: http://gerrit.cloudera.org:8080/#/c/20496/7/be/src/runtime/smallable-string.h@55 PS7, Line 55: other > Nit: could surround 'other' with (single) quotes. Same as on L57. Done -- To view, visit http://gerrit.cloudera.org:8080/20496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741c3a5f12ab620b6b64b57d4c89b5f8e056efd3 Gerrit-Change-Number: 20496 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Oct 2023 11:42:36 +0000 Gerrit-HasComments: Yes
