Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20634 )

Change subject: IMPALA-12530: Make Postgres server to accept remote connections 
from same subnet
......................................................................


Patch Set 1:

(1 comment)

I don't see any unwarranted security impact from this change.

http://gerrit.cloudera.org:8080/#/c/20634/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/20634/1/bin/bootstrap_system.sh@392
PS1, Line 392: ubuntu sudo sed -ri 's/host +all +all +127.0.0.1\/32/host all 
all samenet/g' \
This is only going to update the IPv4 line. We could technically use

  listen_addresses = '0.0.0.0'

to match that.

I also wonder if 'samehost' would be sufficient, since they're all local 
containers.



--
To view, visit http://gerrit.cloudera.org:8080/20634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfaf38bf9178cb2ec7ef15c79c17a5ab1e1c6dc
Gerrit-Change-Number: 20634
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Mon, 30 Oct 2023 20:19:19 +0000
Gerrit-HasComments: Yes

Reply via email to