Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20617 )

Change subject: IMPALA-12515: Build modules for extra pythons
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20617/2/shell/impala-shell
File shell/impala-shell:

http://gerrit.cloudera.org:8080/#/c/20617/2/shell/impala-shell@52
PS2, Line 52:   dirs=( $(cd ${SHELL_HOME} && echo ext-py*) )
            :   vers="${dirs[@]#ext-py}"
When I run these commands locally, I don't see the ext-py removed beyond the 
first one:

# In ${IMPALA_HOME}/shell/build/impala-shell-4.4.0-SNAPSHOT
$ dirs=$(echo ext-py*)
$ vers="${dirs[@]#ext-py}"
$ echo $vers
2 ext-py3

Another option would be:
$ versions=$(ls -d ext-py* | sed 's#ext-py##' | sed ':a; N; $!ba; s/\n/, /g')
$ echo $versions
2, 3

Got the sed magic from https://www.baeldung.com/linux/join-multiple-lines#sed



--
To view, visit http://gerrit.cloudera.org:8080/20617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13720a9e3c50f348bef41f5e91f810204e416f13
Gerrit-Change-Number: 20617
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Tue, 31 Oct 2023 17:02:42 +0000
Gerrit-HasComments: Yes

Reply via email to