Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20584 )

Change subject: IMPALA-12493: Allow retry after failed cancel_query
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20584/4/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/20584/4/tests/webserver/test_web_pages.py@919
PS4, Line 919:   @pytest.mark.execute_serially
             :   def test_query_cancel_created(self):
Have you look at test_cancellation.py?

It might be simpler to test there by also injecting DebugAction sleep when 
transitioning out of INITIALIZED/CREATE state.
https://github.com/apache/impala/blob/d9f1271c96393245c3022129603d1080b206addc/be/src/service/client-request-state.cc#L1279



--
To view, visit http://gerrit.cloudera.org:8080/20584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24
Gerrit-Change-Number: 20584
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 31 Oct 2023 17:55:49 +0000
Gerrit-HasComments: Yes

Reply via email to