Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )
Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@52 PS1, Line 52: import java.io.File; nit: don't need. http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@191 PS1, Line 191: Path localJarPath = new Path(localPath); : // Delete the jar file once its loaded : FileSystemUtil.deleteIfExists(localJarPath); To be safe, delete the local jar file in ExternalDataSourceExecutor.release() function https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java#L189 http://gerrit.cloudera.org:8080/#/c/20639/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/20639/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@20 PS1, Line 20: import java.io.IOException; nit: keep alphabet order, move this line after line #21 -- To view, visit http://gerrit.cloudera.org:8080/20639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004 Gerrit-Change-Number: 20639 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2023 21:30:09 +0000 Gerrit-HasComments: Yes
