Sai Hemanth Gantasala has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20367 )

Change subject: IMPALA-10976: Sync db/table in catalogD to latest HMS event id 
after the DDL operation for all DDLS from Impala clients
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20367/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/20367/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1113
PS4, Line 1113:           reloadMetadata = false;
> alterTableAddPartitions() and alterTableDropPartition() already modify the
I have already made changes such that the cache is not updated after the HMS 
operation, instead it relies on MetastoreEventsProcessor.

alterTableAddPartitions() --> If syncToLatestEventId is set to true, we don't 
invoke catalog_.addPartition(), instead update the cache using 
MetastoreEventsProcessor.syncToLatestEventId().
alterTableDropPartition() --> If syncToLatestEventId is set to true, we don't 
invoke catalog_.dropPartitions(), instead update the cache using 
MetastoreEventsProcessor.syncToLatestEventId().

Please see the added test in CatalogHmsSyncToLatestEventIdTest class 
https://gerrit.cloudera.org/c/20367/5/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java#255
MetaStoreEventsProccesor updates the cache and verifies that EventsProcessor's 
events are skipped.



--
To view, visit http://gerrit.cloudera.org:8080/20367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf
Gerrit-Change-Number: 20367
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Wed, 01 Nov 2023 00:51:53 +0000
Gerrit-HasComments: Yes

Reply via email to