Hello Wenzhe Zhou, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20641
to look at the new patch set (#2).
Change subject: IMPALA-12532: Fix bug in cancel_query_and_validate_state
......................................................................
IMPALA-12532: Fix bug in cancel_query_and_validate_state
test_cancellation.py was silently buggy for not exercising exec_option
combinations configured at TestCancellation::execute_cancel_test().
change_database() should not be called right after set_configuration()
in cancel_util.py::cancel_query_and_validate_state(). This is because
change_database() will erase all configuration that was previously set.
This patch fix the issue by calling change_database() first before
set_configuration(). Similar pattern also fixed in
test_admission_controller.py.
Testing:
- Manually run test_cancellation.py and confirm at coordinator log that
query options are set properly.
Change-Id: Ie908fc1384279482892c3f8b2cfa3592e54f9d5a
---
M tests/custom_cluster/test_admission_controller.py
M tests/util/cancel_util.py
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/20641/2
--
To view, visit http://gerrit.cloudera.org:8080/20641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie908fc1384279482892c3f8b2cfa3592e54f9d5a
Gerrit-Change-Number: 20641
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
