Hello Quanlong Huang, Riza Suminto, Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20584
to look at the new patch set (#5).
Change subject: IMPALA-12493: Allow retry after failed cancel_query
......................................................................
IMPALA-12493: Allow retry after failed cancel_query
Previously if /cancel_query failed with "Query not yet running",
subsequent attempts to cancel the query would always fail and the query
would never be unregistered (so it would stay in "queries in flight" or
"waiting to be closed" until the coordinator was restarted) because the
QueryDriver thought the query was finalized. Check whether the query is
inflight before setting finalized_ to allow retries.
Cancelling a request can no longer fail, so checks for whether the query
is inflight are moved to the callers.
Two ClientRequestState::Finalize calls that previously passed
check_inflight=true no longer check inflight. Retried queries should
always reach inflight before they need to be finalized. They were added
in IMPALA-10413 and IMPALA-10414 with no explanation why check inflight
was needed, and still pass their tests.
Testing:
- adds a test that canceling a query in CREATED state fails but does not
prevent canceling the query later
- adds a test that canceling a query that later fails results in that
query completing rather than going to "waiting to be closed"
Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24
---
M be/src/runtime/query-driver.cc
M be/src/runtime/query-driver.h
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/impala-server.cc
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/util/DebugUtils.java
M tests/webserver/test_web_pages.py
8 files changed, 174 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/20584/5
--
To view, visit http://gerrit.cloudera.org:8080/20584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24
Gerrit-Change-Number: 20584
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
