Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20612/8/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/20612/8/be/src/scheduling/scheduler.cc@312 PS8, Line 312: > This calculation is confusing me a little bit. I would expect it to read "t Done http://gerrit.cloudera.org:8080/#/c/20612/8/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test: http://gerrit.cloudera.org:8080/#/c/20612/8/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test@184 PS8, Line 184: # or exactly 1 if MAX_NUM_FILTERS_AGGREGATED_PER_HOST equals to num executors > The minicluster has 3 nodes, but this works because we exclude the coordina That is correct. Rephrased the comment. -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2023 21:31:20 +0000 Gerrit-HasComments: Yes
