Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 )
Change subject: IMPALA-12493: Allow retry after failed cancel_query ...................................................................... Patch Set 6: Verified+1 (2 comments) Trivial update. http://gerrit.cloudera.org:8080/#/c/20584/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20584/5//COMMIT_MSG@21 PS5, Line 21: They were added : in IMPALA-10413 and IMPALA-10414 with no explanation why check inflight : was needed - presumably it was done bec > I think the reason is the new query is marked as in-flight here: Ack. I can update the commit message to reflect that thinking. http://gerrit.cloudera.org:8080/#/c/20584/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20584/5/be/src/service/client-request-state.cc@1474 PS5, Line 1474: void ClientRequestState::Cancel(const Status* cause, bool wait_until_finalized) { : { > nit: can fit a single line Done -- To view, visit http://gerrit.cloudera.org:8080/20584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24 Gerrit-Change-Number: 20584 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 15:56:49 +0000 Gerrit-HasComments: Yes
