Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20629 )
Change subject: IMPALA-12355: Make utility_entrypoint arch-agnostic ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20629/1/docker/utility_entrypoint.sh File docker/utility_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/20629/1/docker/utility_entrypoint.sh@31 PS1, Line 31: LD_LIBRARY_PATH+=:$(dirname $JAVA_SERVER_PATH) : LD_LIBRARY_PATH+=:$JAVA_SERVER_PATH Do you mind if we make this a bit more like daemon_entrypoint.sh? We don't need to support multiple JVMs or non-Ubuntu platforms, but keeping them closer might be nice. Detect JAVA_HOME for Java 8, then code kinda like this: https://github.com/apache/impala/blob/master/docker/daemon_entrypoint.sh#L89-L103 -- To view, visit http://gerrit.cloudera.org:8080/20629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e6b781bef52e60072ff02f4098d5ad9405aa2be Gerrit-Change-Number: 20629 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 22:11:17 +0000 Gerrit-HasComments: Yes
