Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20524 )
Change subject: IMPALA-12426: Adds the backend InternalServer class. ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/20524/13/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20524/13/be/src/service/impala-server.h@1300 PS13, Line 1300: const Status ExecuteAndFetchAllTextInternal(const std::string& user_name,const std::string& sql, line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20524/13/be/src/service/impala-server.h@1302 PS13, Line 1302: const Status FetchAllRowsInternal(const QueryHandlePtr query_handle, query_results& results, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20524/13/be/src/service/internal-server.cc File be/src/service/internal-server.cc: http://gerrit.cloudera.org:8080/#/c/20524/13/be/src/service/internal-server.cc@74 PS13, Line 74: RETURN_IF_ERROR(SetQueryOption(iter->first, iter->second, &session_state->set_query_options, &session_state->set_query_options_mask)); line too long (142 > 90) http://gerrit.cloudera.org:8080/#/c/20524/13/be/src/service/internal-server.cc@209 PS13, Line 209: const Status ImpalaServer::FetchAllRows(const QueryHandlePtr query_handle, query_results& results, line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27686aa563fac87429657e4980b29b0da91eb9e1 Gerrit-Change-Number: 20524 Gerrit-PatchSet: 13 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 22:19:42 +0000 Gerrit-HasComments: Yes
