Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20623 )
Change subject: IMPALA-12516: Set HDFS limit based on memlock ...................................................................... Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20623/10/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/20623/10/bin/bootstrap_system.sh@478 PS10, Line 478: sudo tee ah... so you needed the " | sudo tee ... " form to make the change stick? http://gerrit.cloudera.org:8080/#/c/20623/10/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/20623/10/testdata/cluster/admin@253 PS10, Line 253: let nit: maybe use the $((...)) for for consistency with the following lines? -- To view, visit http://gerrit.cloudera.org:8080/20623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7722ddd0c7fbd9bbd1979503952b7522b808194a Gerrit-Change-Number: 20623 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 06 Nov 2023 19:09:48 +0000 Gerrit-HasComments: Yes
