Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20668 )
Change subject: IMPALA-12542: Wait for query cancellation in webserver test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20668/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/20668/2/tests/webserver/test_web_pages.py@962 PS2, Line 962: response_json = self.try_until("query cancellation", self.get_queries, : lambda resp: resp['num_in_flight_queries'] == 0 > The timeout is 10s. You think that's insufficient? I'd maybe go with 30s with 0.5s interval to avoid flakiness. But 10 might be enough since this run serially. -- To view, visit http://gerrit.cloudera.org:8080/20668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c3bc83955be025e83a426377221767694baa444 Gerrit-Change-Number: 20668 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 06 Nov 2023 23:16:41 +0000 Gerrit-HasComments: Yes
