Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20659 )
Change subject: IMPALA-12527: Fix Iceberg metadata table test S3 paths ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20659/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/20659/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@26 PS2, Line 26: .* Do we need to change the results here even after annotating the test with SkipIf.hardcoded_uris? Btw, instead of $NAMENODE or '.*', $WAREHOUSE_LOCATION_PREFIX might be better. -- To view, visit http://gerrit.cloudera.org:8080/20659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04ee4798c643f7cce59efa80b3327f7f37c80562 Gerrit-Change-Number: 20659 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 Nov 2023 14:11:32 +0000 Gerrit-HasComments: Yes
