Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20684 )
Change subject: IMPALA-12548: Fix behavior of AGG_MEM_CORRELATION_FACTOR ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20684/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20684/2/common/thrift/ImpalaService.thrift@847 PS2, Line 847: // aggregation node can be scheduled with lower memory estimation (lower memScale). > typo: aggregation Done http://gerrit.cloudera.org:8080/#/c/20684/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20684/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@685 PS2, Line 685: // High correlation means aggregation node can be scheduled with lower memory > typo here too Done http://gerrit.cloudera.org:8080/#/c/20684/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/20684/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@1429 PS2, Line 1429: options.setLarge_agg_mem_threshold(512 * 1024 * 1024); > Why not multiply that out? Optimizers are good at precalculating basic arit Done. Thanks for the reminder! -- To view, visit http://gerrit.cloudera.org:8080/20684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f81db32a1818abc257957f6de942b5c9f36211a Gerrit-Change-Number: 20684 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2023 23:31:15 +0000 Gerrit-HasComments: Yes
