Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20676 )
Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties ...................................................................... Patch Set 1: (2 comments) I noticed you added 2 more properties to the hidden tblproperties list in ToSqlUtils.java, that were not listed in the Jira. Could you add them to the commit message as well? http://gerrit.cloudera.org:8080/#/c/20676/1/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/20676/1/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@95 PS1, Line 95: FeTable.LAST_MODIFIED_BY, : FeTable.LAST_MODIFIED_TIME Worth mentioning in the commit message if these properties were not hidden before. http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/20676/1/tests/metadata/test_show_create_table.py@383 PS1, Line 383: tblproperties_to_omit = [ Should LAST_MODIFIED_BY and LAST_MODIFIED_TIME be also included here? -- To view, visit http://gerrit.cloudera.org:8080/20676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6f2cb9194f685a583b0d550532eb2454f119666 Gerrit-Change-Number: 20676 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 10 Nov 2023 16:35:12 +0000 Gerrit-HasComments: Yes
