Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 )
Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables ...................................................................... Patch Set 1: (1 comment) I could not read it all through, just one question. http://gerrit.cloudera.org:8080/#/c/20677/1/fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/20677/1/fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java@167 PS1, Line 167: sortExprs_.add(ref); 'sortExprs_' is defined in ModifyImpl.java and has the following comment: 'For every column of the target table that is referenced in the optional 'sort.columns' table property, this list will contain the corresponding result expr from 'resultExprs_'. Before insertion, all rows will be sorted by these exprs. If the list is empty, no additional sorting by non-partitioning columns will be performed.The column list must not contain partition columns and must be empty for non-Hdfs tables.' This comment does not align with line 167. As far as I understand, the comment suggests, that partitioning columns should not be added to 'sortExprs_'. Should 'sortExprs_' be empty in KuduModifyImpl since Kudu is not a HDFS table? Does anything rely on this variable? Is it shown in the plan? Or maybe the comment needs to be updated? -- To view, visit http://gerrit.cloudera.org:8080/20677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff0ef6075a2b6ebe130d15daa389ac1a505a7a08 Gerrit-Change-Number: 20677 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Nov 2023 10:43:34 +0000 Gerrit-HasComments: Yes
